Add some more Python -> Python3 conversions

ipa320 / rqt_frame_editor_plugin

An rqt plugin for creating, manipulating and managing tf frames.

MIT License

21 stars 11 forks source link

Add some more Python -> Python3 conversions #31

Closed mintar closed 2 years ago

mintar commented 3 years ago

This fixes an error ('dict' object has no attribute 'itervalues') and a warning (about safe_load) when running on Python 3 (ROS Noetic).

mintar commented 3 years ago

This was not tested on Kinetic/Melodic, since I testing GUI applications in Docker is a PITA. I think it should work on Kinetic/Melodic as well, but better check before merging.

BTW: Even with these fixes, frame_editor is still not working on Noetic.

ipa-jsk commented 2 years ago

@ipa-pgt I suggest to merge into the new noetic-devel branch, which is working on Noetic when starting the plugin from a launch file. Your safe_load() call fixes an error when opening the plugin in rqt.

ipa-jsk commented 2 years ago

@mintar the PR has already been merged into noetic-devel branch.

mintar commented 2 years ago

Great, thanks!