Schunk arm moveit configuration files - Githubissues

ipa320 / schunk_robots

www.schunk-modular-robotics.com

29 stars 50 forks source link

Schunk arm moveit configuration files #63

Closed bbrito closed 8 years ago

bbrito commented 8 years ago

I added a folder containing the moveIt configuration files for the Schunk arm using the MoveIt setup assistant.

fmessmer commented 8 years ago

Looks good so far....we will merge after testing on hardware...

Just one minor thing: It would have been nicer to name the package schunk_lwa4d_moveit_config....for consistency with the package naming scheme...

Any issues so far? Please document your progress here....were you able to use the moveit config in demo mode/with simulation/with hardware?

fmessmer commented 8 years ago

Also, did you rename your github-user? Seems like your commit uses @bbrito instead of @ipa-bfb

fmessmer commented 8 years ago

Well, old pkg name is all over (I stopped commenting) maybe it's better to regenerate the package with the correct name!

fmessmer commented 8 years ago

What e-mail did you register for @ipa-bfb? And what e-mail did you use on your laptop when you did git config --global? Are you using the same e-mail for @bbrito?

fmessmer commented 8 years ago

Before merging, we should:

remove the example script
squash the whole PR into a single commit
fix the author from @bbrito to @ipa-bfb

fmessmer commented 8 years ago

LGTM Tested in demo+sim+robot