Closed bbrito closed 8 years ago
Looks good so far....we will merge after testing on hardware...
Just one minor thing:
It would have been nicer to name the package schunk_lwa4d_moveit_config
....for consistency with the package naming scheme...
Any issues so far? Please document your progress here....were you able to use the moveit config in demo mode/with simulation/with hardware?
Also, did you rename your github-user? Seems like your commit uses @bbrito instead of @ipa-bfb
Well, old pkg name is all over (I stopped commenting) maybe it's better to regenerate the package with the correct name!
What e-mail did you register for @ipa-bfb? And what e-mail did you use on your laptop when you did git config --global
? Are you using the same e-mail for @bbrito?
Before merging, we should:
LGTM Tested in demo+sim+robot
I added a folder containing the moveIt configuration files for the Schunk arm using the MoveIt setup assistant.