[CodingIntroduction] Enhancments and Feedback

[fmessmer]

@ipa-mig https://github.com/ipa320/setup/pull/68#issuecomment-142926478

[mgruhler]

More Points (some shamelessly copied from #68) for improvements. @ipa320/orga-pull, any more ideas?

• [x] include some "best practices" for package.xml and CMakeLists.txt. E.g.
  • [x] sort dependencies alphabetically
  • [x] for each target, have add_executable/add_library, add_dependencies and target_link_libraries directly after each other
  • [x] use add_dependencies(TARGET ${${PROJECT_NAME}_EXPORTED_TARGETS} and add_dependencies(TARGET catkin_EXPORTED_TARGETS} respectively.
  • [x] delete unnecessary comments out of the files
  • [x] ...
• [x] Maybe we should also add a condensed tl;dr version where the most important DO's and DONT's are mentionend, e.g.
  • [x] Github user name should be ipa-KÜRZEL
  • [x] ...
• [x] Update PR Handling
  • [x] PR Review?
  • [x] Provide a meaninful PR description?
  • [x] How should a PR look like (small, one feature...)?

[floweisshardt]

as #72 is merged now: can this be closed? Or are we still missing something?

[mgruhler]

I think all is included, so can be closed from my point of view.

[floweisshardt]

closing this one. If there are new topics, please open a new issue