ipab-slmc / exotica

Extensible Optimization Framework
https://ipab-slmc.github.io/exotica
BSD 3-Clause "New" or "Revised" License
151 stars 70 forks source link

DDP, iLQG solvers return wrong-sized solution #654

Closed wxmerkt closed 5 years ago

wxmerkt commented 5 years ago

If the problem horizon is T, then:

Two possible solutions: a) The returned solution should be of size T-1 b) The final command should be a hold/inverse dynamics solution or zeros.

I tend to (a).

traikodinev commented 5 years ago

So the issue is this line here: https://github.com/ipab-slmc/exotica/blob/3462afd9928c02989754de09229f7ea6daebea23/exotations/solvers/exotica_ddp_solver/src/abstract_ddp_solver.cpp#L61

The solution is resized to T, not to T - 1, which is the issue (in the first paragraph you said T-1).

traikodinev commented 5 years ago

https://github.com/ipab-slmc/exotica/pull/656