search

ipab-slmc / exotica

Extensible Optimization Framework
https://ipab-slmc.github.io/exotica
BSD 3-Clause "New" or "Revised" License
149 stars 70 forks source link

Updated functionality of EffBox task map #670

Closed cmower closed 4 years ago

cmower commented 4 years ago

[task_maps] Rather than returning whole vector for lower/upper limits, now user specifies the limits of which end-effector they want to have access to [examples] Updated example script to show how python interface to EffBox task map is used to get lower/upper limits

cmower commented 4 years ago

I'm not sure what this error is but all builds and works fine locally.

VladimirIvan commented 4 years ago

Try to compile it in debug mode on your local machine as well: 

catkin config --cmake-args -DCMAKE_BUILD_TYPE=Debug
catkin build

It sometimes catches bugs that the release mode doesn't (e.g., Eigen static asserts). It looks like travis may have just messed up that particular build and everything is OK.

cmower commented 4 years ago

Try to compile it in debug mode on your local machine as well:

catkin config --cmake-args -DCMAKE_BUILD_TYPE=Debug
catkin build

It sometimes catches bugs that the release mode doesn't (e.g., Eigen static asserts). It looks like travis may have just messed up that particular build and everything is OK.

Tried this and no warnings/errors to report. Build succeeds as expected. In this case, I think you're correct that travis is having issues.

All good to merge then? It's quite a simple addition...

wxmerkt commented 4 years ago

When Travis fails, please have a look at the logs there on the source of failure. In this case it says time-out (>50mins) for both Debug configurations. That is not a good sign. You can restart individual sub-builds without the whole build when you login to Travis using your GitHub account (I just did).

If it times out again, this PR (albeit a minor change) may have pushed it over in terms of compilation time or memory exhaustion. This wouldn't be a good sign as it would reduce our overall CI coverage and we may have to either (a) ask travis for runtime extension or (b) set up new CI infrastructure.