ipab-slmc / exotica

Extensible Optimization Framework
https://ipab-slmc.github.io/exotica
BSD 3-Clause "New" or "Revised" License
149 stars 70 forks source link

Clang support and bug fixes #731

Closed wxmerkt closed 3 years ago

wxmerkt commented 3 years ago

This PR fixes compilation under Clang. We've previously relied on a gcc quirk that prevented compilation in Clang. I've also gone ahead and fixed various issues, including incorrect overrides, missing/non-virtual destructors, etc.

This likely has an impact on #360 as it fixes Task destruction but I cannot verify without a reproduction case.

Note, the CI only tests gcc right now.