Closed zardoy closed 1 year ago
TODO add missing test
Once you fix linter errors I'll approve and merge this.
For some reason VSCode is messing with formatting on my end too. I'm just adding extra settings for that to .vscode/settings.json
because it doesn't seem to respect .editorconfig
.
I'm just adding extra settings for that to .vscode/settings.json
What setting? I have editorconfig extension installed, which just configures tab size, which seems to be fine. This is a problem with typescript formatter fighting with eslint
I'm just adding extra settings for that to .vscode/settings.json
What setting? I have editorconfig extension installed, which just configures tab size, which seems to be fine. This is a problem with typescript formatter fighting with eslint
Omg, for some reason I was 100% sure VSCode is one of those which don't need a plugin for editor config to work 🤦🏻♂️
You're right, after installing it works just fine so I reverted the change and added editorconfig for recommended extensions: https://github.com/ipatalas/vscode-postfix-ts/commit/17faaa8db339866749c6bdf4369a9c504f012e57
Two tests are broken and it doesn't seem random because they are both for inside JSX
scenario. Can you check that?
Base: 93.31% // Head: 92.86% // Decreases project coverage by -0.46%
:warning:
Coverage data is based on head (
4b85a37
) compared to base (3a9c27a
). Patch coverage: 65.21% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@ipatalas IMO a better way to fix switch-case formatting issue is to { SwitchCase: 1 }
in options of indent
eslint rule. Because for now if someone ctrl+s or format that file eslint error will popup
@ipatalas IMO a better way to fix switch-case formatting issue is to
{ SwitchCase: 1 }
in options ofindent
eslint rule. Because for now if someone ctrl+s or format that file eslint error will popup
Totally agree, wasn't aware of that.
@ipatalas fixed gh ci
fixes #99