ipatalas / vscode-postfix-ts

Postfix notation for TypeScript/Javascript - extension for VS Code
MIT License
158 stars 43 forks source link

editorconfig shouldnt control eol #106

Closed zardoy closed 1 year ago

zardoy commented 1 year ago

https://github.com/ipatalas/vscode-postfix-ts/pull/103#issuecomment-1403534454

codecov[bot] commented 1 year ago

Codecov Report

Base: 92.86% // Head: 92.86% // No change to project coverage :thumbsup:

Coverage data is based on head (2e7e5be) compared to base (f197af6). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #106 +/- ## ======================================== Coverage 92.86% 92.86% ======================================== Files 24 24 Lines 1416 1416 Branches 253 253 ======================================== Hits 1315 1315 Misses 98 98 Partials 3 3 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ireneusz+Patalas). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ireneusz+Patalas)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ipatalas commented 1 year ago

Funny story, look who added that: https://github.com/ipatalas/vscode-postfix-ts/commit/aad3d8761b3000af7c714288377ee980ed91fb34 :D

But I agree, that should be up to git to handle that on different OSes.