search

ipatalas / vscode-postfix-ts

Postfix notation for TypeScript/Javascript - extension for VS Code
MIT License
159 stars 43 forks source link

`not`: Dont treat assignments as binary expression globally and skip unnecesary scopes #110

Closed zardoy closed 1 year ago

zardoy commented 1 year ago

fixes https://github.com/ipatalas/vscode-postfix-ts/issues/109 fixes https://github.com/ipatalas/vscode-postfix-ts/issues/108#issuecomment-1429719522

partially fixes https://github.com/ipatalas/vscode-postfix-ts/issues/108 (at least for all of my cases)

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 :tada:

Comparison is base (66204f1) 92.92% compared to head (2dcbcfd) 92.96%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #110 +/- ## =========================================== + Coverage 92.92% 92.96% +0.03% =========================================== Files 24 24 Lines 1428 1436 +8 Branches 256 260 +4 =========================================== + Hits 1327 1335 +8 Misses 98 98 Partials 3 3 ``` | [Impacted Files](https://codecov.io/gh/ipatalas/vscode-postfix-ts/pull/110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ireneusz+Patalas) | Coverage Δ | | |---|---|---| | [src/postfixCompletionProvider.ts](https://codecov.io/gh/ipatalas/vscode-postfix-ts/pull/110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ireneusz+Patalas#diff-c3JjL3Bvc3RmaXhDb21wbGV0aW9uUHJvdmlkZXIudHM=) | `88.67% <100.00%> (ø)` | | | [src/templates/baseTemplates.ts](https://codecov.io/gh/ipatalas/vscode-postfix-ts/pull/110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ireneusz+Patalas#diff-c3JjL3RlbXBsYXRlcy9iYXNlVGVtcGxhdGVzLnRz) | `96.85% <100.00%> (ø)` | | | [src/templates/notTemplate.ts](https://codecov.io/gh/ipatalas/vscode-postfix-ts/pull/110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ireneusz+Patalas#diff-c3JjL3RlbXBsYXRlcy9ub3RUZW1wbGF0ZS50cw==) | `96.29% <100.00%> (+0.91%)` | :arrow_up: | | [src/utils/typescript.ts](https://codecov.io/gh/ipatalas/vscode-postfix-ts/pull/110?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ireneusz+Patalas#diff-c3JjL3V0aWxzL3R5cGVzY3JpcHQudHM=) | `98.43% <100.00%> (-0.18%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ireneusz+Patalas). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ireneusz+Patalas)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

zardoy commented 1 year ago

@ipatalas done. Didn't do it on purpose as wanted to know why didn't you add new in these cases, but forgot to write another message to reach out you

ipatalas commented 1 year ago

@ipatalas done. Didn't do it on purpose as wanted to know why didn't you add new in these cases, but forgot to write another message to reach out you

Oh, ok. Well, quite frankly I don't remember. Now when I look at it it looks reasonable to include it there too so perhaps I just overlooked that back then.

zardoy commented 1 year ago

Thanks!