infer variable name improvements

[zardoy]

• fix for https://github.com/plurals/pluralize/issues/192#issuecomment-1079970233

• enable proposal of multiple variants

• also needs fix for something.messages.forof

[zardoy]

I thing I'm going to revert last commit as there is no need to display not clean variant. Though it was interesting to explore. I thing it might be useful in future to suggest multiple variants for cases like: users[0].const -> firstUser|user

[ipatalas]

Wow, that's super cool! I love the idea!

[zardoy]

Though I still didn't figure out how to fix something.messages.forof template

[ipatalas]

Though I still didn't figure out how to fix something.messages.forof template

What do you mean? How is it broken? Seems to work unless you mean to infer message from that - if so then it's super easy, I'll handle that.

[ipatalas]

Two lines of code and one minute later:

[ipatalas]

Also made another small improvement:

[zardoy]

From my POV these cases are pretty common and we should support them:

for (let command of MenuRegistry.getCommands()) {
}

Shouldn't be hard since we have both extraction functions in place, try to do this soon or you can handle them

[ipatalas]

Correct, that's a very common case. I'm on my phone now but i already know it's another 2 lines of code so i will implement that if i have 15 minutes this weekend 😉

[zardoy]

Also what do you think of this pattern? Do you think its common and we can handle it?

for (let indexToPatch of indexesToPatch) {
}

index -> indexes Edit: I think it can be related to https://github.com/ipatalas/vscode-postfix-ts/pull/72#issuecomment-1249440174 (not about additional, suggestions)