search

ipatix / agbplay

Music player for the most common GBA sound format
GNU Lesser General Public License v3.0
118 stars 21 forks source link

Use Correct Values for GB Pan #30

Closed Kurausukun closed 4 years ago

Kurausukun commented 4 years ago

Fixes Issue #19 The current values for determining GB pan snapping (-32 and 32) are not accurate. I found these values through testing using an actual GBA ROM, so they should be accurate.

ipatix commented 4 years ago

So, I now checked and although you just tried these values, they actually are correct.

What seems to cause the pan snapping in CgbModVol is basically "if one side is twice the amplitude as the other side, then snap to that side". I originally thought that this would happen at +-32, but now that I go through the numbers, your values actually are the correct ones.