search

ipatix / agbplay

Music player for the most common GBA sound format
GNU Lesser General Public License v3.0
118 stars 21 forks source link

Live MIDI mode #61

Closed wildfirekithara closed 1 year ago

wildfirekithara commented 1 year ago
ipatix commented 1 year ago

Sounds interesting. Do you still intend to get this merged?

wildfirekithara commented 6 months ago

ah, sorry about that. i opened this by mistake (meant to PR onto my fork repo instead of this repo). this was just a one off thing for someone who needed to create MIDIs for the sound engine using a pre-built soundbank. this allowed them to compose in their DAW and have something relatively accurate to how it would sound in game. for one, as you know, things like volume and velocity calculations are wildly different in MP2k vs. standard MIDI. and then there are very specific behaviors like vibrato etc.

mostly decided to keep the fork up in the case someone else might happen to have this exact niche use case. but it's definitely not in a state to be merged or anything, there's a bunch of hacky things to get it to work on latest macOS and things patched into structs/classes haphazardly on the fly without a well thought out change to the architecture with the aim of just getting it to work good and accurate enough for the purpose.