search

ipatix / gba-hq-mixer

This repository contains multiple versions of my so called "HQ mixer" for GBA games which use the m4a/mp2k sound driver.
GNU General Public License v3.0
36 stars 6 forks source link

R0/R6 issue? #8

Closed easyaspi314 closed 2 years ago

easyaspi314 commented 2 years ago

I was trying to document the code (and convert to unified syntax so it can compile with Clang's built-in assembler), and noticed this: https://github.com/ipatix/gba-hq-mixer/blob/main/m4a_hq_mixer.s#L890-910 L891 and L900 both refer to R6 in the comment, but actually operate on R0. It seems like the rest of the code expects it to be in R6 like the comment.

ipatix commented 2 years ago

If my memory serves me well, I don't know why R6 would make any sense there. I'll correct it.

ipatix commented 2 years ago

Huh, I thought I already fixed this... Apparently I forgot