search

ipbus / ipbb

IPbus Builder Tool
GNU General Public License v3.0
12 stars 12 forks source link

`ipbb vivado generate-project` throws exception when when not defining any .tcl/vhdl2008/library files #186

Closed thasti closed 1 year ago

thasti commented 1 year ago

When creating a project that defines no .tcl/vhdl2008/library files, project generation fails:

...
generate-project | .../firmware/xdc/timing.xdc
ERROR: exception caught!
'prop'
generate-project | Vivado% quit

I traced this error to https://github.com/ipbus/ipbb/blob/develop/src/ipbb/generators/vivadoproject.py#L173 - the issue seems to be that the generator iterates through the possible types of commands (add, ip, prop), but line 177 has no handling for the case when one of these keys don't exist.

In my particular case, this was triggered when I moved all my constraint files from .tcl to .xdc, and as such they are then simply added through the add group instead of the prop group (leaving it empty).