Robustify the RHEL8 check and fix a typo

ipbus / ipbb

IPbus Builder Tool

GNU General Public License v3.0

12 stars 12 forks source link

Robustify the RHEL8 check and fix a typo #192

Closed jhegeman closed 7 months ago

jhegeman commented 7 months ago

Two small changes:

Be more careful with the check for RHEL8-based systems. Now fully backward compatible with CentOS 7 as well.
Fix a distracting typo in an output message.

jhegeman commented 7 months ago

This version seems to work better. It works on 'CentOS Linux release 7.9.2009 (Core)' and on 'AlmaLinux release 8.9 (Midnight Oncilla)', even though CentOS and Alma seem to have picked different conventions for the REDHAT_SUPPORT_PRODUCT_VERSION attribute.

tswilliams commented 7 months ago

@jhegeman Thanks for updating. I've tested the new logic in CentOS7, Alma 8, Alma 9, Rocky 8, Rocky 9 and Ubuntu 22 docker containers, and need_workaround was only True for Alma 8 & Rocky 8. So it looks good to me; merging now .