ipbus / ipbus-firmware

Firmware that implements a reliable high-performance control link for particle physics electronics, based on the IPbus protocol
https://ipbus.web.cern.ch
Other
39 stars 31 forks source link

Bumping DRP address width to 16 bits #153

Closed jhegeman closed 4 years ago

jhegeman commented 4 years ago

Bumping DRP address width to 16 bits, in order to support UltraScale+ GTH/GTY.

This should settle issue #150.

Please note: as far as I can see, this change is not exercised by any of the tests. This could change after adding the sysmon examples from pull request #145.

jhegeman commented 4 years ago

Hi Tom,

This branch has been updated after the recent PR merges. I checked the VCU118 Xilinx example and that builds.

Cheers, Jeroen

tswilliams commented 4 years ago

Hi,

Thanks. I just noticed some inconsistency in the indentation one of the DRP files (and one other slave file). I've fixed that in commit d5f5396

Can you update the branch for this pull request to point to that commit? You can do this as follows:

git remote add github-ipbus https://github.com/ipbus/ipbus-firmware.git
git fetch github-ipbus

# Assuming the 'remote' for your fork of the IPbus repo is named "origin" (if not replace origin in following command with whatever name you used - that name can be found by running "git remote -v")
git push -f origin d5f5396b6b157e13a7c97758c453536765403c01:ipbus_issue150

Cheers, Tom

jhegeman commented 4 years ago

Ok, done.

tswilliams commented 4 years ago

run tests, please

tswilliams commented 4 years ago

@jhegeman : Thanks! Just waiting for the automated builds to finish now.

tswilliams commented 4 years ago

@jhegeman : Sorry, the commit I pointed you to earlier was somehow out of date with respect to the latest master branch. Can point your branch instead to commit d065939 ? I.e:

git remote add github-ipbus https://github.com/ipbus/ipbus-firmware.git
git fetch github-ipbus

# Assuming the 'remote' for your fork of the IPbus repo is named "origin" (if not replace origin in following command with whatever name you used - that name can be found by running "git remote -v")
git push -f origin d065939c778bc4126e1940c13255bbc7b4a3b037:ipbus_issue150

Sorry again for the mistake!

Cheers, Tom

jhegeman commented 4 years ago

Ok, done. No worries. It looks like it now insists you redo the tests though ;-)