search

ipbus / ipbus-firmware

Firmware that implements a reliable high-performance control link for particle physics electronics, based on the IPbus protocol
https://ipbus.web.cern.ch
Other
41 stars 32 forks source link

VC707 ethernet block #160

Closed ixiotidi closed 4 years ago

ixiotidi commented 4 years ago

I am adding the Ethernet block I created in order to have a stable IPbus design running in a Xilinx VC707 board

tswilliams commented 4 years ago

Hi,

Thanks for opening this pull request, and contributing the Ethernet block. (And sorry for the delay in responding.)

As far as I'm aware, this Ethernet block should be equally usable in any SGMII-based 7-series design. Is that correct? If so, could you change the name of the entity/file from eth_vc707_sgmii(.vhd) to eth_7s_smgii(.vhd)?

Cheers, Tom

ixiotidi commented 4 years ago

Hi Tom,

thanks for the reply. I will do the change in the next days. However, just to let you know the reason I put that as SGMII in vc707 is because I only have tested in the VC707 board with the marvell chips mounted there. I don't know if another board would require a certain configuration of the IP cores.

Cheers --Ioannis

tswilliams commented 4 years ago

Hi,

Since the renaming was easy for me to do, I renamed this Ethernet block in another branch, and merged that branch into the master in pull request #173

So this Ethernet block from this pull request is now present in the master branch of the repo. Thanks again for opening this PR.

Cheers, Tom