Improve the device DNA reading state machine

ipbus / ipbus-firmware

Firmware that implements a reliable high-performance control link for particle physics electronics, based on the IPbus protocol

https://ipbus.web.cern.ch

Other

39 stars 31 forks source link

Closed jhegeman closed 7 months ago

jhegeman commented 7 months ago

This patch improves the device DNA reading FSM a bit.

It adds a (more interesting) value for use in simulation.
It avoids the Vivado complaint that 'WARNING: [Synth 8-3332] Sequential element (dna_reader/FSM_onehot_fsm_state_reg[3]) is unused and will be removed from module ipbus_device_dna_us_usp.'
It cleans a few things up (although this point can be debated).

tswilliams commented 7 months ago

Run tests, please

tswilliams commented 7 months ago

@jhegeman : I've just created a new tag containing this fix - v1.14