ipbus / ipbus-firmware

Firmware that implements a reliable high-performance control link for particle physics electronics, based on the IPbus protocol
https://ipbus.web.cern.ch
Other
39 stars 31 forks source link

Improve ipbus drp bridge #236

Closed jhegeman closed 4 months ago

jhegeman commented 5 months ago

The original implementation of the ipbus_drp_bridge did not allow for a DRP clock different from the IPBus clock. This new implementation does. A generic allows one to choose at implementation time whether or not to include an IPBus clock bridge. The default values for the generic and the new DRP clock input port should ensure that this is fully backwards-compatible.

tswilliams commented 5 months ago

Hi @jhegeman

Thanks for these changes. They look good to me, just one minor comment: I spotted that stb2_d - and hence also stb2 - is ultimately not used. I just wanted to check that this isn't an indication that you'd forgotten to push some additional logic which uses those signals.

jhegeman commented 5 months ago

Hi @tswilliams,

Well spotted! These are left-overs from an intermediate implementation, in which they were used to tweak the busy signal. I have removed them now.

Cheers, Jeroen

tswilliams commented 5 months ago

Run tests