search

ipdxco / github-as-code

GitHub Configuration as Code
19 stars 7 forks source link

feat: added issue label support #102

Closed galargh closed 1 year ago

galargh commented 1 year ago

This PR adds support for labels!

It also includes changes from https://github.com/protocol/github-mgmt-template/pull/101 because I happened to have them half-done in the editor when I started working on the label support 🤷

Testing

Label support has been rolled out to pl-strflt/github-mgmt. Here's a PR that modifies some labels https://github.com/pl-strflt/github-mgmt/pull/110 and a fix for it https://github.com/pl-strflt/github-mgmt/pull/111 (it turns out label descriptions do not allow unicode).

galargh commented 1 year ago

Tested in testground too: https://github.com/testground/github-mgmt/commit/0eb33c95934da38cb92556ec02436b74ca5fe7a1

galargh commented 1 year ago

I'm gonna merge it since it's now rolled out everywhere. During testing in large orgs, I discovered that tracking individual labels is too inefficient for large orgs (like libp2p for example). We'll have to rework label support so that it works on collections instead i.e. tracking all the labels for a repo as a single resource instead of every label being its own resource.