ipeaGIT / aopdata

Download data from the Access to Opportunities Project (AOP)
https://ipeagit.github.io/aopdata/
13 stars 4 forks source link

aopdata archived on CRAN #37

Closed rafapereirabr closed 2 years ago

rafapereirabr commented 2 years ago

for the same reason as geobr.

rafapereirabr commented 2 years ago

Package aopdata v1.0.0 submitted to CRAN with the following comment:

-- R CMD check results ------------------------------------------ aopdata 1.0.0 ---- Duration: 4m 40.5s

0 errors v | 0 warnings v | 0 notes v

  • This is a submission to get the package back on CRAN.

The aopdata package was suspended on CRAN on February 2022 because it continuously failed CRAN's policy to "fail gracefully" when there are any internet connection problems.

We have scrutinized the package, which has now gone through strcutural changes to address this issue. Here are the main changes:

  1. New internal function check_connection() and tests that cover cases when users have no internet connection, whem url links are offline, time out or work normally.
  2. All functions that require internet connection now use check_connection() and return informative messages when url links are offline or timeout.
  3. The data used in the pacakge is now simultaneously stored in two indepentend servers, where one of them is used as a backup link. In other words, the aopdata will download the data from server 1. If, some some reason, the download fails because of internet connection problems, then aopdata tries to download the data from server 2. If this second attempt fails, then package returns invisible(NULL) with an informative message.

We believe these changes and the redundancy in data storage have made the aopdata package substantially more robust and in line with CRAN's policies.

rafapereirabr commented 2 years ago

CRAN feedback:

Dear maintainer,

package aopdata_1.0.0.tar.gz does not pass the incoming checks automatically, please see the following pre-tests: Windows: https://win-builder.r-project.org/incoming_pretest/aopdata_1.0.0_20220811_154355/Windows/00check.log Status: 2 NOTEs Debian: https://win-builder.r-project.org/incoming_pretest/aopdata_1.0.0_20220811_154355/Debian/00check.log Status: 2 NOTEs

Please fix all problems and resubmit a fixed version via the webform. If you are not sure how to fix the problems shown, please ask for help on the R-package-devel mailing list: https://stat.ethz.ch/mailman/listinfo/r-package-devel If you are fairly certain the rejection is a false positive, please reply-all to this message and explain.

More details are given in the directory: https://win-builder.r-project.org/incoming_pretest/aopdata_1.0.0_20220811_154355/ The files will be removed after roughly 7 days.

No strong reverse dependencies to be checked.

Best regards, CRAN teams' auto-check service Flavor: r-devel-windows-x86_64 Check: CRAN incoming feasibility, Result: NOTE Maintainer: 'Rafael H. M. Pereira [rafa.pereira.br@gmail.com](mailto:rafa.pereira.br@gmail.com)'

New submission

Package was archived on CRAN

Possibly misspelled words in DESCRIPTION: AOP (20:26) aopdata (15:14)

CRAN repository db overrides: X-CRAN-Comment: Archived on 2022-02-06 for repeated policy violation.

On Internet access.

Found the following (possibly) invalid URLs: URL: https://www.tidyverse.org/lifecycle/#experimental (moved to https://lifecycle.r-lib.org/articles/stages.html#experimental) From: README.md Status: 200 Message: OK

Flavor: r-devel-linux-x86_64-debian-gcc, r-devel-windows-x86_64 Check: R code for possible problems, Result: NOTE Found if() conditions comparing class() to string: File 'aopdata/R/utils.R': if (class(x) == "try-error") ... Use inherits() (or maybe is()) instead.

Flavor: r-devel-linux-x86_64-debian-gcc Check: CRAN incoming feasibility, Result: NOTE Maintainer: 'Rafael H. M. Pereira [rafa.pereira.br@gmail.com](mailto:rafa.pereira.br@gmail.com)'

New submission

Package was archived on CRAN

Possibly misspelled words in DESCRIPTION: AOP (20:26) aopdata (15:14)

CRAN repository db overrides: X-CRAN-Comment: Archived on 2022-02-06 for repeated policy violation.

On Internet access.

Found the following (possibly) invalid URLs: URL: https://www.tidyverse.org/lifecycle/#experimental (moved to https://lifecycle.r-lib.org/articles/stages.html#experimental) From: README.md Status: 301 Message: Moved Permanently