ipeaGIT / geobr

Easy access to official spatial data sets of Brazil in R and Python
https://ipeagit.github.io/geobr/
778 stars 116 forks source link

Fix not reaching download mirror #312 #316

Closed vss-2 closed 10 months ago

rafapereirabr commented 10 months ago

Hi @vss-2 , could you please check why this PR is not passing package tests?

vss-2 commented 10 months ago

Hello, I'm closing and opening this PR to trigger a re-run of tests. I suspect the previous run failed due to a config issue at that point. If not, please disregard this comment.

vss-2 commented 10 months ago

Checking out: it seems I've forgotten to add pull_request triggers on line 1 of Python-CMD-check. To make Python GHA package-testing equals to R the first line should be replaced to something like:

on:
  push:
    paths:
      - python-package/**
    branches:
      - main
      - master
      - dev
  pull_request:
    paths:
      - python-package/**
    branches:
      - main
      - master
      - dev

Also, I've scrolled entirely AppVeyor history and I couldn't find a successful build in the past four years. It seems AppVeyor notifications aren't providing useful statuses anymore.

rafapereirabr commented 10 months ago

Ok, would you like to add pull_request triggers to Python-CMD-check first? or in this pull request?

vss-2 commented 10 months ago

Just to make sure this PR will try to reach the download mirrors, I will include the pull_request code first. Next, if the GHA doesn't trigger automatically, I will re-run this PR.

rafapereirabr commented 10 months ago

thanks !