search

ipeaGIT / geobr

Easy access to official spatial data sets of Brazil in R and Python
https://ipeagit.github.io/geobr/
794 stars 119 forks source link

[python] Fix missing html5lib dependency #348 #349

Closed vss-2 closed 5 months ago

vss-2 commented 5 months ago

Adds html5lib to Poetry's dependencies in order to fix python package testing pipeline.

vss-2 commented 5 months ago

Sorry for the excessive commits. The thing is: besides the missing package, the current Python implementation of list_geobr(), which goes to Github README.md and downloads the whole HTML then crops the table containing the dataset is no more valid. It seems the codification have changed or it's something related to front-end (React table building lib mixing unicode characters) changes that makes previous code unable to identify where the table is (that's why the last commit has an emoji 👉 inside the code). I've achieved a way to adapt by identifying the table using regular expressions maintaining the expected behavior.

rafapereirabr commented 5 months ago

thanks, @vss-2 !!