ipeaGIT / r5r

https://ipeagit.github.io/r5r/
Other
183 stars 31 forks source link

Simplify JDK download instructions #366

Closed mattwigway closed 10 months ago

mattwigway commented 10 months ago

The download instructions on https://ipeagit.github.io/r5r/ for the JDK are currently somewhat confusing to someone not well versed in Java. We currently link to two pages for getting the JDK:

neither of which actually provide a JDK download anymore. I think we should pick one of the three open source JDK implementations, and just link to that. Anyone who has a preference for what JDK to use is going to ignore these instructions anyways. The three I'm familiar with are:

I am usually running either Temurin or Corretto on my machines, I haven't touched anything from Oracle in years. Conveyal uses Corretto to run the R5 test suite.

mattwigway commented 10 months ago

Adoptium/Temurin might be the best choice as it autodetects platform/architecture so people won't have difficulty if they don't know what CPU they have.

rafapereirabr commented 10 months ago

Hi Matt. These are great suggestions. I'm happy with recommending Temurin, but I wouldn't see a problem in simply mentioning other implementations and linking to them

mattwigway commented 10 months ago

I'm not sure why the auto builder rebuilt the jar for the pull request - will investigate.

On Mon, Jan 29, 2024, 7:31 PM Rafael H M Pereira @.***> wrote:

Hi Matt. These are great suggestions. I'm happy with recommending Temurin, but I wouldn't see a problem in simply mentioning other implementations and linking to them

— Reply to this email directly, view it on GitHub https://github.com/ipeaGIT/r5r/issues/366#issuecomment-1915828253, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEKNLVYC2FYUB2BHPAU6I3YRA5PFAVCNFSM6AAAAABCQG2PMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJVHAZDQMRVGM . You are receiving this because you authored the thread.Message ID: @.***>