search

ipeadata-lab / ipeaplot

ipeaplot: criando graficos no padrão editorial do Ipea
https://ipeadata-lab.github.io/ipeaplot/
Other
1 stars 0 forks source link

vline and hline as parameters? #14

Closed rafapereirabr closed 10 months ago

rafapereirabr commented 10 months ago

In the ggplot2 grammar, there is a there are geoms to add horizontal and vertical lines (geom_hline() and geom_vline()).

I see that the current version of the package includes vline and hline as parameters of scale_color_ipea() and scale_fill_ipea(). Imho, this doesn't make sense. The scale_*_ipea() should only relate to color palettes and legends. The vertical and horizontal lines we add to plots are not related to those.

I would suggest remove these two parameters.

PedroJorge7 commented 10 months ago

Como sugerido, eu removi os argumentos da função.