search

ipedrazas / drone-helm

Helm (Kubernetes) plugin for drone.io
MIT License
120 stars 90 forks source link

Plugin package #64

Closed jmccann closed 6 years ago

jmccann commented 6 years ago

Taking another stab at #59

jmccann commented 6 years ago

I know there are conflicts in this PR now. But I wanted to know @ipedrazas if you had any thoughts on this before I try to update it again.

My goal is to be able to use this plugin also as a library inside other plugins. I'm currently doing this with an internal fork I have. Would love to not have to maintain a fork for this. The problem is that currently all code is package "main" which you can not import.

Thanks!

josmo commented 6 years ago

@jmccann just fyi I'm publishing images to https://hub.docker.com/r/peloton/drone-helm/ based on the fork at https://github.com/josmo/drone-helm (it also has the conversions you made to make the plugin package. @ipedrazas definitely let me know if you're still maintaining this and want me to PR all my changes back in (and also if you need a ci server to publish things up :) ) :)

josmo commented 6 years ago

@jmccann can probably close this out :) #69 has the changes to be able to be a plugin in it.

jmccann commented 6 years ago

Awesome! Thanks @josmo