search

ipedrazas / drone-helm

Helm (Kubernetes) plugin for drone.io
MIT License
120 stars 90 forks source link

Implement helm dependency update #66

Closed tdabasinskas closed 6 years ago

tdabasinskas commented 6 years ago

In case the locally defined Chart contains requirements.yaml file, which specifies external dependency charts, the deployment via plugin would fail, as these external charts must exist in the ./charts/ sub-directory.

To resolve this, the PR includes additional update_dependencies: true parameter, which, when specified, runs helm dependency update CHART command prior running the main upgrade command.

That's my first PR for this repository, so please let me know if any additional changes are required.

tdabasinskas commented 6 years ago

Thanks for merging this, @ipedrazas.

Any plans for a new release, including this and few previews changes, soon?

ipedrazas commented 6 years ago

Mmmm, a new docker image should be created after merging the pr.

I’ve moved it to google container builder. Perhaps it’s not working as I expected. Let me check.

On 12 Jun 2018, at 19:34, Tomas Dabasinskas notifications@github.com wrote:

Thanks for merging this, @ipedrazas.

Any plans for a new release, including this and few previews changes, soon?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

tdabasinskas commented 6 years ago

Thanks!

I've noticed the latest image in https://quay.io/ipedrazas/drone-helm dates back beginning of May, that's why the question.