ipedrazas / drone-helm

Helm (Kubernetes) plugin for drone.io
MIT License
120 stars 90 forks source link

build changes - go dep, doc updates, purge fixed, namespace plugin moved #69

Closed josmo closed 6 years ago

josmo commented 6 years ago

@ipedrazas I can separate out all the changes in different prs however here's the summary

generally if you accept the pr and use drone to build/publish you only need a couple secrets (docker_username, docker_password, plugin_repo) and you're good to go :)

josmo commented 6 years ago

Should include #64 I do realize it's a bit massive so let me know how you want it split to bring in :)

ipedrazas commented 6 years ago

This is massive 😂😂😂

I’ve just realised I’ve,lost visibility on the tests... which is not great. I’m currently on holidays so, I have very limited time. Anything you could do to minimise the time I need to spend checking this PR would be highly appreciated.

josmo commented 6 years ago

@ipedrazas I can definitely create a few smaller PRs (let me know if that's easier), but I'll summarize all the changes which if I split would probably represent the separate PRs. I definitely got a bit carried away last night ;)

Here's where I'm currently building the plugin - https://drone.pelo.tech/josmo/drone-helm

  1. go dep - This is most of the file changes. So vendor folder is now ignored and deleted. Does require the dep ensure prior to tests and builds

  2. Changed to make the plugin a lib from a prior PR. Tests got moved into the plugin module so running them with go test ./... -v -cover will still run all the same tests

  3. the .drone.yml file has the deps, test, build, and publishing in it. It's generic so that any fork can easily build and publish their own version of the plugin but just enabling the fork in their drone and setting up a couple secrets. It also has the update to tag and build versions in the binary. also using the cli you can just DRONE_REPO_OWNER=ipedrazas DRONE_REPO_NAME=drone-helm drone exec to build the product locally

  4. Split out the usage into docs to make the readme a bit simpler to view

  5. Updated kubectl to 1.11.0

  6. Fixed purge value not being initialized into the plugin.

  7. gofmt

If you're down for one big PR. There's two updates left. Changing the couple places in the readme that reference my repo, and the build.sh needs to place the build product where the dockerfile expects it since I was using drone to build it.

josmo commented 6 years ago

@ipedrazas Hope you're doing well and holidays went well or are still going well :) just wanted to see how you wanted me to do this? One big PR or getting you 7 smaller ones :)