search

ipedrazas / drone-helm

Helm (Kubernetes) plugin for drone.io
MIT License
120 stars 90 forks source link

Set string flag #70

Closed mgar closed 6 years ago

mgar commented 6 years ago

Currently, --set parses number only values as float64.

This command helm install --set long_string_value=1234567890 will result into setting 1.23456789e+09 in the template.

This PR adds string_values as a new configuration key to pass long int variables, which will be converted into string using the --set-string helm flag.

mgar commented 6 years ago

I think this is ready to merge after fixing all conflicts.

@josmo , please note that you left an import from your own fork in the main.gofile. I reverted it back to use @ipedrazas code.

josmo commented 6 years ago

@mgar oh thanks! totally missed that