possible to remove package https://github.com/alecthomas/template

ipedrazas / drone-helm

Helm (Kubernetes) plugin for drone.io

MIT License

120 stars 90 forks source link

possible to remove package https://github.com/alecthomas/template #73

Closed chrisduong closed 5 years ago

chrisduong commented 5 years ago

Hi,

I checked the package, it is a fork of GO built-in text/template package. The feature it provided is to trim Newlines, which it is actually can be done with Go. For e.g:

{{- if true -}}
hello
{{-end}}

Will produce

hello\n

I have tested in CI, it is actually not needed. If someone can tell me more about this package's usage, I'm happy to know it. Thanks

ipedrazas commented 5 years ago

If you think it's not needed, raise a PR and let's clean it up.

chrisduong commented 5 years ago

Hi @ipedrazas, I had submitted the PR. 🙂 https://github.com/ipedrazas/drone-helm/pull/75