Try to avoid IFD in `vendorCargoDeps` and `crateNameFromCargoToml`; also avoid recommending nesting `cleanCargoSource` and `path`

ipetkov / crane

A Nix library for building cargo projects. Never build twice thanks to incremental artifact caching.

https://crane.dev

MIT License

962 stars 92 forks source link

Try to avoid IFD in `vendorCargoDeps` and `crateNameFromCargoToml`; also avoid recommending nesting `cleanCargoSource` and `path` #641

Closed ipetkov closed 5 months ago

ipetkov commented 5 months ago

Motivation

We don't need to nest cleanCargoSource and path just to populate a default value for name. As they both ultimately delegate to builtins.path, the nesting can lead to IFD in situations which are otherwise avoidable

Fixes https://github.com/ipetkov/crane/issues/612

Checklist

[ ] added tests to verify new behavior
[x] added an example template or updated an existing one
[x] updated docs/API.md (or general documentation) with changes
[x] updated CHANGELOG.md