search

ipeychev / liferay-aui-upgrade-tool

1 stars 1 forks source link

Quotation marks being added to scriptlets #15

Closed robframpton closed 11 years ago

robframpton commented 11 years ago

This issue seems to be caused by commit cf4fb14 - Fix #9 Change "handler" to "on: click" for Toolbar

Before:

cssClass='<%= showConnectedRequestedIcon ? "disabled" : "disabled aui-helper-hidden" %>'

After:

cssClass='<%=' showConnectedRequestedIcon ? "disabled" : "disabled helper-hidden" %>'

Notice the extra single quotation after the opening of the scriptlet. Same thing is happening with double quotations.

Before:

<li class="<%= phone.isPrimary() ? "primary" : "" %>">

After:

<li class="<%=" phone.isPrimary() ? "primary" : "" %>">

This appears to only happen in 'class', 'cssClass', and 'className' properties. For example.

<aui:input cssClass="<%= scriptlet %>">
<div class="<%= scriptlet %>">
<liferay-ui:ratings
    className="<%= scriptlet %>"
/>

These scriptlets would all receive the extra quotation mark.

However, the issue does not occur with the 'classPK' property.

robframpton commented 11 years ago

Hey @ipeychev,

I updated the description of the issue, I narrowed it down to three properties that receive the extra quotation.