ipfans / echo-session

Package echo-session is a middleware that provides session support for echo.
Apache License 2.0
67 stars 36 forks source link

Handler clearance neglected? #7

Closed 0x7061 closed 7 years ago

0x7061 commented 7 years ago

In the gorilla/session description it states:

Important Note: If you aren't using gorilla/mux, you need to wrap your handlers with context.ClearHandler as or else you will leak memory! An easy way to do this is to wrap the top-level mux when calling http.ListenAndServe: http.ListenAndServe(":8080", context.ClearHandler(http.DefaultServeMux))

Echo is using an own router so I'm wondering if this middleware is already doing that to avoid memory leaks?

Source> http://www.gorillatoolkit.org/pkg/sessions

ipfans commented 7 years ago

This issue is be fixed, thanks for your report.