search

ipfs-cluster / ipfs-cluster-website

The IPFS Cluster website
https://ipfscluster.io
MIT License
42 stars 50 forks source link

Implement toggle feature for left nav #94

Closed tapaswenipathak closed 5 years ago

tapaswenipathak commented 5 years ago

Fix https://github.com/ipfs/ipfs-cluster-website/issues/91.

meiqimichelle commented 5 years ago

Hi @tapaswenipathak ! Thank you for the contribution! I pulled your branch down and tested it locally, and I'm not sure I see where your change is implemented. I think you may have worked off master instead of the new-docs-layout branch. I might be misunderstanding though -- could you add a screenshot of your change in action? Thank you again!

tapaswenipathak commented 5 years ago

Hello @meiqimichelle: I didn't know new-docs-layout branch exist, rebasing and merging. From the ticket comment I don't think toggle feature is implemented. I just looked at the new-docs-layout branch, correct me if I'm wrong.

meiqimichelle commented 5 years ago

Ah, sorry for the confusion! Your contribution came just as I was iterating on the layout, and removing the need for a toggle to simplify everything. I'll open a WIP PR so it's a little clearer what's in progress! :-/