search

ipfs-examples / helia-examples

How to do most anything with your Helia node
https://verified-fetch.vercel.app
72 stars 62 forks source link

feat: helia-lan-discovery example #136

Closed SgtPooki closed 8 months ago

SgtPooki commented 1 year ago

user reached out on slack about peer discovery not working quite right with Helia, so i decided to throw together some code and try it out

This example is now working and has some very basic tests

achingbrain commented 1 year ago

Related: https://github.com/libp2p/js-libp2p/issues/2012

achingbrain commented 1 year ago

Also related: https://github.com/libp2p/js-libp2p/pull/2013

SgtPooki commented 8 months ago

Merged this even though test-monorepo is failing

achingbrain commented 8 months ago

Merged this even though test-monorepo is failing

😞

achingbrain commented 8 months ago

This was missing a repo to copy the examples to so it further broke the build.

I've updated the instructions for adding new examples which were a little out of date, I think it's all present & correct now - https://github.com/ipfs-examples/helia-examples#how-to-add-a-new-example

achingbrain commented 8 months ago

That said the tests are pretty unreliable, the lan example ones seem to run forever sometimes. There was a timeout cli command before the tests, presumably that just kills them if they take too long, which should probably be fixed instead?