search

ipfs-inactive / bifrost-gateway

Experimental gateway with delegated backend. No longer maintained, consider migrating to https://github.com/ipfs/rainbow/
Other
41 stars 20 forks source link

Use IPIP-412 parameters to request ordered CARs with duplicates rather than defaults #177

Open aschmahmann opened 1 year ago

aschmahmann commented 1 year ago

IPIP-412 introduces the order and dups parameters for CAR retrievals using the HTTP Gateway API. Currently bifrost-gateway does not use these parameters and changes like #160 assume that order=dfs; dups=y is what's used by default.

We should switch to order=dfs; dups=y so that we are not tied to the default behavior of backing-gateways like Saturn.

This is an easy enough switch to do, but will cause cache in Saturn so flagging folks to make sure we're ready to do this.

cc @aarshkshah1992 @DiegoRBaquero @willscott @lidel

hannahhoward commented 1 year ago

From a lassie standpoint, this is fine. We already parse the dups param and act on it.