search

ipfs-inactive / ci-sync

[ARCHIVED] CI dashboard for Protocol Labs projects
http://ci-sync.cloud.ipfs.team/
4 stars 6 forks source link

AppVeyor - `npm test` vs `npm test:node` #5

Open victorb opened 6 years ago

victorb commented 6 years ago

The currently synced config for AppVeyor is using npm run test:node for launching the tests, for nodejs only. https://github.com/ipfs/ci-sync/blob/992f127d79012a262fb0895ad72ddab4b387ab5e/configs/appveyor.yml#L27

However, js-datastore-fs is only exposing a npm run test, not test:node: https://github.com/ipfs/js-datastore-fs/blob/ac2d6872d7960703b7bb2cc6b42a688e88dd30d0/package.json#L6-L16

Either, AppVeyor should just run npm test, which I'm not sure if AppVeyor can handle, as it would launch browser tests for repositories that got that.

Or, change js-datastore-fs to expose both test and test:node which would essentially do the same thing in the end.

daviddias commented 6 years ago

Or, change js-datastore-fs to expose both test and test:node which would essentially do the same thing in the end.

👍