search

ipfs-inactive / ci-sync

[ARCHIVED] CI dashboard for Protocol Labs projects
http://ci-sync.cloud.ipfs.team/
4 stars 6 forks source link

Move coverage test to Circle CI (now it is on Travis) #6

Open daviddias opened 6 years ago

daviddias commented 6 years ago

@VictorBjelkholm can you use your script to move all the Coverage runs to Circle CI instead of Travis?

Currently, it is https://github.com/ipfs/js-ipfs-repo/blob/master/.travis.yml#L21-L22, we want https://github.com/ipfs/js-ipfs-api/blob/master/circle.yml#L7

We also want to default to coveralls and not codecov. Make the line be:

npm run coverage -- --upload --providers coveralls

Thank you!

victorb commented 6 years ago

Is this something that is urgent and needs to be changed now? Otherwise, we can proceed as we are with updating CI everywhere, and once migration is done, I can write a script that can change that directly in master, bypassing the PRs.

daviddias commented 6 years ago

@VictorBjelkholm we want coverage to be run on PRs so that we know if the PR is lowering or increasing the coverage.

Right now we have a bunch of unknowns here https://github.com/ipfs/js-ipfs#packages

daviddias commented 6 years ago

@VictorBjelkholm I see that the config was updated -- https://github.com/ipfs/ci-sync/blob/master/configs/circle.yml#L11 -- but there hasn't been a PR to change this in all the repos. What's the hold up?

victorb commented 6 years ago

@diasdavid I want to change the flow of the script before running it again, as it's destructive, see https://github.com/ipfs/ci-sync/blob/master/make-ci-update-pr.js#L25