search

ipfs-inactive / dev-team-enablement

[ARCHIVED] Dev Team Enablement Working Group
3 stars 1 forks source link

Previous jobs are not cancelled #109

Open victorb opened 6 years ago

victorb commented 6 years ago

From @vmx on March 16, 2018 13:40

If another job is triggered and other ones on the same PR are still in the queue, those old outdated ones are not cancelled, but also run. This jams up Jenkins more then necessary.

Copied from original issue: ipfs/jenkins#99

victorb commented 6 years ago

Thanks. Supposedly, it cancels previous builds if a new commit is made to a PR but seems like it's currently not working. Will look into it as this will degrade jenkins performance significantly.

victorb commented 6 years ago

From @alanshaw on August 6, 2018 10:6

+1 on this - also smarts for not building the same commit if one is already running unless it was user requested. I'm also getting a double build for the same commit as I often push a branch and then immediately open a PR.

I can open a separate issue if you want @VictorBjelkholm?

victorb commented 6 years ago

@alanshaw no, think is fine.

Regarding double builds, idea was that branches would be tested in isolation and PRs are tested as they are merged into master, but since we almost never push branches without opening PRs, it might be better to just skip the builds that happens on branches, only do PR builds.