Electron Forge build error on Windows

ipfs-inactive / dev-team-enablement

[ARCHIVED] Dev Team Enablement Working Group

3 stars 1 forks source link

Electron Forge build error on Windows #131

Closed hacdias closed 5 years ago

hacdias commented 5 years ago

Which Project is this about?

IPFS Desktop.

Provide a link to a example run where it went wrong

https://ci.ipfs.team/blue/organizations/jenkins/IPFS%20Shipyard%2Fipfs-desktop/detail/PR-651/2/pipeline

Which platform did the issue happen on?

Windows

It also happened on my computer. Apparently it is using Python 3 instead of Python 2, hence the error. I just cleaned my python installations and then installed windows-build-tools (https://www.npmjs.com/package/windows-build-tools) et voilá.

hacdias commented 5 years ago

Ping @VictorBjelkholm

victorb commented 5 years ago

@hacdias the steps for the windows CI for ElectronForge builds are here: https://github.com/ipfs/jenkins-libs/blob/master/vars/electronForge.groovy#L14-L40

Should be simple for you to add the installation of that package right before doing the build itself :)

hacdias commented 5 years ago

@VictorBjelkholm although, looking at the error, we see that Python 3 is already installed, but I can add windows-build-tools there.

The command line needs to be running as admin though. Is it?

hacdias commented 5 years ago

Ping @VictorBjelkholm

hacdias commented 5 years ago

@VictorBjelkholm we can close this! We're working on a new branch for IPFS Desktop and it will have its own Jenkinsfile with the steps on it. After that branch is merged, I'll create a PR to remove electronForge from jenkins libs.