search

ipfs-inactive / dev-team-enablement

[ARCHIVED] Dev Team Enablement Working Group
3 stars 1 forks source link

Windows worker out of space & clean-workspaces erroring #135

Closed alanshaw closed 5 years ago

alanshaw commented 6 years ago

Which Project is this about?

Jenkins CI

screen shot 2018-09-10 at 12 16 13

Provide a link to a example run where it went wrong

https://ci.ipfs.team/view/System/job/clean-workspaces/

Which platform did the issue happen on?

Windows

alanshaw commented 6 years ago

Still happening today :(

victorb commented 6 years ago

Fixed the script to not fail entirely if it fails to delete one directory (seems gx is keeping itself running at some points). Works better now.

There is a separate issue on Windows workers only though, as it seems the cleanWS function doesn't really delete the files as it does on macOS and Linux workers. Will be looking into that closer.

alanshaw commented 6 years ago

FYI, a while ago I made changes to js-ipfs to clean up after itself to help alleviate this problem, but for failures and timeouts it might not cleanup.

Really, I think we don't want any state hanging around on the machines from prior runs. It would be nice if the machine could just be reset to a given state for each run.

lidel commented 6 years ago

I also got Error: ENOSPC: no space left on device, write on Windows:

Not sure why, Companion's Jenkinsfile should do cleanup at the end, even on error:

} finally {
  cleanWs()
}

Did it run out of space due to an other project/issue or is cleanWs() not as effective as I assumed?

daviddias commented 5 years ago

Still an issue? Consolidate with the CI exploration on ipfs/infra?

lidel commented 5 years ago

I am quite sure @victorb squashed this specific one (some temp files were not cleared properly on Windows).