Pipeline doesn't stop if there was an error

ipfs-inactive / dev-team-enablement

[ARCHIVED] Dev Team Enablement Working Group

3 stars 1 forks source link

Pipeline doesn't stop if there was an error #152

Closed vmx closed 5 years ago

vmx commented 5 years ago

Which Project is this about?

js-ipfs

Provide a link to a example run where it went wrong

https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fjs-ipfs/detail/PR-1626/2/pipeline/

There was an issue on some Windows worker, though the pipeline proceeded.

victorb commented 5 years ago

It's on purpose. The codecov is the only thing that will actually not work if the nodejs tests doesn't work. But just because codelint/commitlint doesn't work, doesn't mean we shouldn't run the rest of the tests.