search

ipfs-inactive / dev-team-enablement

[ARCHIVED] Dev Team Enablement Working Group
3 stars 1 forks source link

JavaScript Projects: run browser tests in CI only #159

Closed daviddias closed 5 years ago

daviddias commented 5 years ago

From @mikeal at https://github.com/ipfs/community/issues/338

One thing I've found that makes contributing very difficult to our JavaScript projects is the browser tests. I've never actually been able to successfully run any of our browser tests in any of the JS projects I've contributed to.

I've gotten in the habit of running test:node and then committing and push with--no-verify which is not a great solution.

There's probably a lot that we can do to improve the runability and reliability of the browser tests, like moving to puppeteer, but that's going to take time. In the meantime, I'd like to remove this barrier to contribution by changing the JS project pre-commit and pre-push definitions to run test:node only.

We should make sure that CI is running the browser tests before contributions get merged, but having them run before every commit and push is rather painful.

daviddias commented 5 years ago

JS Team (@alanshaw, @hugomrdias, @achingbrain), is this something you could take on?

alanshaw commented 5 years ago

Pre-commit/push hooks were removed from most PL JS projects in https://github.com/ipfs/aegir/pull/243 in part because of https://github.com/ipfs/js-ipfs-http-client/pull/794. So this issue has already been resolved as they do run successfully in CI.

If the browser tests are not working for people locally we need an issue created in the repo for the project, or I need a mention in the issue if you create it somewhere else...but that's less ideal as it prevents others working on it or knowing it exists and I'm just going to open an issue in the relevant project for it anyway 🙄

(If an issue already exists and I've missed it somehow then please ignore 😆)