search

ipfs-inactive / dev-team-enablement

[ARCHIVED] Dev Team Enablement Working Group
3 stars 1 forks source link

Jobs not properly cleaning up after themselves #60

Closed victorb closed 6 years ago

victorb commented 6 years ago

Discovered in https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fjs.ipfs.io/detail/master/38/pipeline where files from previous runs existed in the next runs.

Websites jobs need to clean up after themselves, even when they previously fail.

victorb commented 6 years ago

worked after cleaning the workspace: https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fjs.ipfs.io/detail/master/48/pipeline

so basically what's wrong is that if a build is failing, it doesn't clean up after itself which for ipfs/js.ipfs.io is a problem when doing the linting, as the build seems to create files that the linter doesn't ignore

victorb commented 6 years ago

Seems we also hit another issue where things are not actually cleaned up but rather renamed, seems to be this issue: https://issues.jenkins-ci.org/browse/JENKINS-24824

victorb commented 6 years ago

Yeah, confirmed that Jenkins is unable to clean the workspace, due to permissions of the files fetched during the docker build as root and not being able to delete them as worker user.

Due to the workspace cleanup being async, the error only showed up after the pipeline finished in a background process.

victorb commented 6 years ago

Also need to make sure all containers are being removed properly after being used. Think that's missing here as well.

victorb commented 6 years ago

Closing this in factor of https://github.com/ipfs/testing/issues/118