ipfs-inactive / jenkins

[ARCHIVED] Configuration for IPFS's build system
https://ci.ipfs.team/blue
8 stars 6 forks source link

Close docker containers when Jenkins pipeline is killed #27

Closed Kubuxu closed 7 years ago

Kubuxu commented 7 years ago

Acceptance Criteria

Tasks

Notes

Original post from @Kubuxu

It will proceed to run in backround and keep using resources.

victorb commented 7 years ago

Hm, interesting. So "Pipeline is killed" is when you forcefully stops the job or is there an error happening?

Kubuxu commented 7 years ago

When you stop a job via the UI. I think some combination of -t and -i flags is in play here.

victorb commented 7 years ago

Ah, ok, I understand. So when you stop a pipeline, the docker container continuous to run, when it should be stopped together with the pipeline. Probably there is some hook in the Jenkinsfile we can use, on-end or something like that, where we can forcefully kill the containers involved in the pipeline.

Kubuxu commented 7 years ago

Yeah, something like that. There is docker workflow plugin which might help.

Kubuxu commented 7 years ago

Resolved by the docker workflow plugin. If you want to take a look how it works with more complex pipeline see go-ipfs Jenkinsfile.