search

ipfs-inactive / js-ipfs-unixfs-exporter

[ARCHIVED] JavaScript implementation of the UnixFs exporter used by IPFS
MIT License
2 stars 3 forks source link

feat: update to new IPLD API #15

Closed vmx closed 5 years ago

vmx commented 5 years ago

This is part of the Awesome Endeavour: Async Iterators: https://github.com/ipfs/js-ipfs/issues/1670

Currently it checks out IPLD directly from a branch. The reason is that I'd like to get approval from all users of the new API first, so that I can still make changes while keeping the history clean.

achingbrain commented 5 years ago

Thanks for this, very helpful.

When are you planning on releasing the new IPLD API properly and not via a GH url?

I ask because once it's out I will refactor this module and all the other unix-fs/mfs related ones to remove pull-streams and expose an async API as part of the same Awesome Endeavour.

vmx commented 5 years ago

As soon as possible. If I get a thumbsup from you and @alanshaw that the API looks OK, I'll do a release.

achingbrain commented 5 years ago

It doesn't look like the README in the API changes branch has been updated to document the new API, is the latest source of truth still ipld/js-ipld#185 ?

vmx commented 5 years ago

@achingbrain Yes https://github.com/ipld/js-ipld/pull/185 is the source of truth, I also updated it.

vmx commented 5 years ago

https://github.com/ipld/js-ipld/pull/190 is the implementation https://github.com/ipld/js-ipld/pull/185 is the API docs update.

achingbrain commented 5 years ago

Superseded by #21