ipfs-inactive / js-ipfs-unixfs-importer

[ARCHIVED] JavaScript implementation of the UnixFs importer used by IPFS
MIT License
5 stars 4 forks source link

fix: validate rabin args #32

Closed achingbrain closed 5 years ago

achingbrain commented 5 years ago

go-ipfs requires a min chunk size of 16 and will use that for the max/avg if they are set smaller than the min, so perform the same sort of validation.

achingbrain commented 5 years ago

Can do, though it's validated/defaulted by superstruct when the module is in use.

dirkmc commented 5 years ago

In that case I don't think it's necessary to re-validate

achingbrain commented 5 years ago

Ah, did it anyway - can't hurt 😄

dirkmc commented 5 years ago

Cool LGTM :)