search

ipfs-inactive / js-ipfs-unixfs-importer

[ARCHIVED] JavaScript implementation of the UnixFs importer used by IPFS
MIT License
5 stars 4 forks source link

fix: progress callback is optional #43

Closed alanshaw closed 4 years ago

alanshaw commented 4 years ago

This was causing an error when no progress option was specified

achingbrain commented 4 years ago

This should be handled by the merge-options call. Is it being passed in as null?

alanshaw commented 4 years ago

Yes - https://github.com/ipfs/js-ipfs/blob/master/src/http/api/resources/files-regular.js#L216

achingbrain commented 4 years ago

options.progress should be a function, not a null value. If you pass undefined instead this won't be necessary.