search

ipfs-inactive / js-ipfs-unixfs-importer

[ARCHIVED] JavaScript implementation of the UnixFs importer used by IPFS
MIT License
5 stars 4 forks source link

Rabin tests fail on current master #5

Closed vmx closed 5 years ago

vmx commented 5 years ago

The rabin module doesn't compile successfully on Linux. The problem is in the nan module.

Steps to reproduce:

npm install
npx mocha --timeout 5000 --ui bdd --colors --exit test/node.js --grep rabin

The tests will pass after installing an older version of nan:

npm install --save-optional nan@2.11.0
vmx commented 5 years ago

Upstream bug is: https://github.com/nodejs/nan/issues/832.

vmx commented 5 years ago

The upstream bug got fixed and if i do a fresh install locally, tests pass.