search

ipfs-inactive / js-ipfs-unixfs-importer

[ARCHIVED] JavaScript implementation of the UnixFs importer used by IPFS
MIT License
5 stars 4 forks source link

chore: require 0.15.2 of ipld-dag-pb to have name memoisation #7

Closed achingbrain closed 5 years ago

vmx commented 5 years ago

You might want to explicitly also upgrade to the just release ipld 0.20.2.

achingbrain commented 5 years ago

Do you think these should have been minors?

vmx commented 5 years ago

For dag-pb I'm not sure anymore. After your comment that it might lead to issues if you have two different versions installed. On the other hand, if that's a bugfix release all dependencies will automatically move to it, so it's less likely we end up with two different versions.

For js-ipld: I tested with js-ipfs and it didn't break anything, so I think it's good to go. I keep sub 1.0.0 minor releases for breaking changes and I haven't seen why anything should break.

vmx commented 5 years ago

So I kind of do manual pre 1.0.0 automatic seantic-release. If there is no "BREAKING CHANGE" commit, it won't be a minor.

achingbrain commented 5 years ago

I think we should move everything to v1, but that's another conversation.

The weird case we've encountered is that ipld-dag-pb@0.15.2 is API compatible with ipld-dag-pb@0.15.1 but runtime incompatible.

all dependencies will automatically move to it

I believe this is only true if you have no package-lock.json present, otherwise it'll happily resolve 0.15.0 for ~0.15.0 even if 0.15.2 is available.

vmx commented 5 years ago

I believe this is only true if you have no package-lock.json present, otherwise it'll happily resolve 0.15.0 for ~0.15.0 even if 0.15.2 is available.

Thanks for that information. So it works for CI, but not it real world.